[Updated] D11785: status: gather fixup info at comparison time

[Alphare (Raphaël Gomès)]

This revision now requires changes to proceed.
Alphare added inline comments.
Alphare requested changes to this revision.

INLINE COMMENTS

> context.py:1820
>                  else:
> -                    fixup.append(f)
> +                    # XXX not that we have a race windows here since we gather
> +                    # the stats after we compared so the file might have

/s/not/note/

> context.py:1824
> +                    #
> +                    # However this have been the case because and the
> +                    # refactoring moving the code here is improving the

You accidentally a word

> context.py:1867
> +                            for f, pdf in fixup:
> +                                normal(f, pdf)
>                              # write changes out explicitly, because nesting

Maybe make the keyword explicit to be clearer? `normal(f, parentfiledata=pfd)`

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D11785/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D11785

To: marmoute, #hg-reviewers, Alphare
Cc: Alphare, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20211124/9ba26b4b/attachment-0002.html>