[Commented On] D11722: rhg: implement the debugignorerhg subcommand

[Alphare (Raphaël Gomès)]

Alphare added a comment.


  In D11722#181171 <https://phab.mercurial-scm.org/D11722#181171>, @aalekseyev wrote:
  
  > @Alphare, folded commit seems better than the separate ones in this case, though, since the second commit is simply incorporating review comments, not really an independent change.
  > I ran `hg fold --from .^` followed by `hg phabsend .` to make this less confusing.
  > If you were thinking of a certain logical split of this commit into two that I'm not aware of, please let me know.
  
  Sure, most of the time, changes can be incorporated into the same changeset, but for ones that move a lot of code around (like refactor suggestions), we usually like to split them. This has a two-fold advantage of making the review of the actual change more obvious, and to make sure a mistake didn't appear in the refactor.
  
  In this case, I should have been more explicit: I saw two concatenated commit messages and figured you already had two changesets, so I asked you to send them as separate.
  
  Basically: one changeset == one phab diff

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D11722/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D11722

To: aalekseyev, #hg-reviewers, Alphare
Cc: Alphare, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20211129/acd65d20/attachment-0002.html>