[Updated] D11722: rhg: implement the debugignorerhg subcommand

[Alphare (Raphaël Gomès)]

This revision now requires changes to proceed.
Alphare added a comment.
Alphare requested changes to this revision.


  Yes, I think in this case a separate changeset for the type refactor (of the old code) would make sense.
  
  Also I was sure I added a comment about the `println!` usage, but I must have forgotten!

INLINE COMMENTS

> debugignorerhg.rs:37
> +    let patterns = ignore_matcher.debug_get_patterns();
> +    println!("{}", String::from_utf8_lossy(patterns));
> +    Ok(())

This should use `ui.write_stdout`, which would also remove the need for the potentially lossy utf8 conversion.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D11722/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D11722

To: aalekseyev, #hg-reviewers, Alphare
Cc: Alphare, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20211129/f0f980d5/attachment-0002.html>