[Commented On] D11548: hg-core: silence dead-code warning by adding RevlogEntry::revion() accessor
martinvonz (Martin von Zweigbergk)
phabricator at mercurial-scm.org
Fri Oct 1 20:10:58 UTC 2021
martinvonz added a comment.
In D11548#177122 <https://phab.mercurial-scm.org/D11548#177122>, @martinvonz wrote:
> In D11548#177121 <https://phab.mercurial-scm.org/D11548#177121>, @Alphare wrote:
>
>> I'm not sure what the issue is, I pushed the commit after importing it using `phabimport`?
>
> That's `2caf1de2` that you pushed? That commit is not an ancestor of `@`, which points to `789475ef` (my queued version of your commit).
> The obslog for my commit looks like this:
>
> $ hg obslog 2caf1de2
> o 2caf1de2 martinvonz D11548 2021-10-01 08:44 -0700
> | hg-core: silence dead-code warning by adding RevlogEntry::revion() accessor
> | rewritten from f6b47a535937 using phabsend by martinvonz at 2021-10-01 08:45 -0700
> |
> x f6b47a53 martinvonz obsolete 2021-10-01 08:44 -0700 rewritten using phabsend as 97020:2caf1de2fbe4
> hg-core: silence dead-code warning by adding RevlogEntry::revion() accessor
>
> There's no mention of it being rewritten by you there.
> How does it look on your machine?
Oh, could it be that the import was lossless and `hg phabimport` thus created the same commit id as I already had? In that case the only problem is that the `default` branch has diverged (did you `hg push -f`?). I'll fix that.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D11548/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D11548
To: martinvonz, #hg-reviewers, Alphare
Cc: Alphare, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20211001/4d30c8d6/attachment-0002.html>
More information about the Mercurial-patches
mailing list