[Updated] D11675: bookmarks: move the `mirror` option to the `paths` section

marmoute (Pierre-Yves David) phabricator at mercurial-scm.org
Mon Oct 18 07:21:44 UTC 2021


marmoute added inline comments.

INLINE COMMENTS

> spectral wrote in urlutil.py:778
> Sorry for not noticing this in the first review: should `as` be `has`?
> 
> Would it make sense to put the actual value `%s` in quotes in case it's empty, to avoid a message like:
> 
> `(paths.foo:bookmarks.mode has unknown value )`
> 
> (Having the message be enclosed in `()` makes this less necessary, so I'm fine either way)

It would make a lot of sense, I though I did.

I fixed that. Thanks!

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D11675/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D11675

To: marmoute, #hg-reviewers, spectral
Cc: spectral, valentin.gatienbaron, pulkit, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20211018/aa44dc27/attachment-0002.html>


More information about the Mercurial-patches mailing list