[Commented On] D11650: rhg: handle null changelog and manifest revisions

[Alphare (Raphaël Gomès)]

Alphare added a comment.


  This breaks the CI: https://foss.heptapod.net/mercurial/mercurial-devel/-/jobs/254045
  
  It seems that the previous assumption made in the code was that null revs were to be shortcut and this assumption was not changed everywhere. @aalekseyev The easiest way of making sure you're not breaking anything is to push a topic to https://foss.heptapod.net/mercurial/mercurial-devel (if you create an account I can give you the rights to do so).
  
  Right now other tests are failing, so you might see unrelated failures, but I'm looking into those as well. I try to keep the CI is mostly green, but I was on vacation.

INLINE COMMENTS

> test-empty-manifest-index.t:1
> +Create a repo such that the changelog entry refers to a null manifest node:
> +

Does the test suite already have a test for empty manifest or is this specific to `rhg`? I'm asking because I don't think mixing `rhg` config options within "normal tests" is a good idea. There is `test-rhg.t` that is specifically done to test the differences (or lack thereof) and the fallback mechanism.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D11650/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D11650

To: aalekseyev, #hg-reviewers, martinvonz
Cc: Alphare, SimonSapin, martinvonz, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20211018/4f4770fe/attachment-0002.html>