[Updated] D11679: rhg: internally, return a structured representatioon from hg cat

[aalekseyev (Arseniy Alekseyev)]

aalekseyev added a comment.


  In D11679#179111 <https://phab.mercurial-scm.org/D11679#179111>, @Alphare wrote:
  
  > However I wonder if the fragmented allocations have a measurable impact on performance for a case with a large output (in both number of files and number of lines). Do you have a way of testing this easily?
  
  I've ran the same benchmarks I used to measure the impact of https://phab.mercurial-scm.org/D11616 and saw no noticeable difference. (the difference was on the order of 1ms, and not always in the same direction)
  
  By the way, we only introduce extra fragmented allocations in the case when files have metadata.
  If the file has no metadata, then we're just keeping around buffers created when reading the file, so I expect we're actually making one fewer copy of the data.
  I don't know (and didn't measure) which is the  common case.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D11679/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D11679

To: aalekseyev, #hg-reviewers
Cc: Alphare, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20211018/831a2835/attachment-0002.html>