[Commented On] D11688: dirstate-v2: preserve the fallback values on disk

[mharbison72 (Matt Harbison)]

mharbison72 added a comment.


  LGTM

INLINE COMMENTS

> dirstate-v2.txt:576-579
> +    Should be ignored if `HAS_FALLBACK_EXEC` is unset. If set the file for this
> +    entry should be considered executable if that information cannot be
> +    extracted from the file system. If unset it should be considered
> +    non-executable instead.

Looking further ahead to the UI, it would feel weird if it was a command that only worked on Windows.  Is the plan to simply chmod+x the file on !windows, and then continue on looking to the filesystem like is done now?  Is that too complicated with symlinks (where you'd have to delete the existing file/symlink and create a symlink/file when the filesystem supports symlinks)?

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D11688/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D11688

To: marmoute, #hg-reviewers
Cc: mharbison72, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20211019/769607f9/attachment-0002.html>