[Commented On] D11674: path: keep the path instance in the `pulloperation`

danchr (Dan Villiom Podlaski Christiansen) phabricator at mercurial-scm.org
Mon Oct 25 09:58:38 UTC 2021


danchr added a comment.


  In `hg-git`, we currently intercept `mercurial.exchange.pull()` and need to keep compatibility with both the upcoming release and earlier releases. The API change here — inserting a named argument _before_ a positional used by earlier releases — is rather obnoxious to work around. Sure, it's possible, but it won't be pretty…
  
  Please consider moving the new argument to the end.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D11674/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D11674

To: marmoute, #hg-reviewers, pulkit, Alphare
Cc: danchr, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20211025/7de0327b/attachment-0002.html>


More information about the Mercurial-patches mailing list