[Commented On] D11680: push: add option to abort on dirty working copy if parent is pushed

[martinvonz (Martin von Zweigbergk)]

martinvonz added a comment.


  Kyle message made me realize that I had not sent mine, so I'm doing that now.

INLINE COMMENTS

> marmoute wrote in commands.py:5638
> >>   To match other UI better we could have a --check-dirty flag that would turn the feature on and an --no-check-dirty who disable it.
> 
> 
> 
> > Do you mean a tri-state flag? Where do we currently use that?
> 
> I am not sure what is your question here ? We allowing --no- variant for boolean flags has been around for a while and is used in various places.  Including with a config option that control the default value. (e.g. `hg update --merge`)

> I am not sure what is your question here ? We allowing --no- variant for boolean flags has been around for a while and is used in various places.

If the default value of the flag is `False`, then passing `--no-check-dirty` is the same as not passing it. Do you mean that the default should be `None` (i.e. a tri-state)?

What other flag(s) were you thinking of that use `--check-*` rather than `--allow-*`?

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D11680/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D11680

To: martinvonz, #hg-reviewers
Cc: spectral, marmoute, pulkit, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20211026/1fb0e7f4/attachment-0002.html>