[Commented On] D11212: wireprotov1peer: update all rpcs to use the new batchable scheme

[danchr (Dan Villiom Podlaski Christiansen)]

danchr added a comment.


  In D11212#174524 <https://phab.mercurial-scm.org/D11212#174524>, @Alphare wrote:
  
  > In D11212#174426 <https://phab.mercurial-scm.org/D11212#174426>, @danchr wrote:
  >
  >> In D11212#173796 <https://phab.mercurial-scm.org/D11212#173796>, @Alphare wrote:
  >>
  >>> I don't think the backwards compatibility concerns are too bad, but I might be wrong.
  >>
  >> Please note that this breaks `hg-git`, as it currently relies on the `future` for wrapping a repository. We'll probably have to come up with a wrapper regardless.
  >> See e.g. https://foss.heptapod.net/mercurial/hg-git/-/blob/branch/default/hggit/gitrepo.py#L113
  >
  > Thanks for bringing this up. Does that represent a large amount of work for you?
  
  Well, my main challenge here is that I have absolutely no idea what's going on — I don't have much experience with the very low levels of networking in Mercurial, or the (relatively) new peer API. It seems to me that the point of that code is, essentially, to provide a minimal repository or peer that does nothing. Could something like that be moved to Mercurial core?

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D11212/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D11212

To: valentin.gatienbaron, #hg-reviewers, Alphare
Cc: danchr, Alphare, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mercurial-scm.org/pipermail/mercurial-patches/attachments/20210907/e66e9d44/attachment-0001.html>