[Request] [+ ] D11492: rust: Remove some obsolete doc-comments

SimonSapin phabricator at mercurial-scm.org
Thu Sep 23 17:42:29 UTC 2021


SimonSapin created this revision.
Herald added a reviewer: hg-reviewers.
Herald added a subscriber: mercurial-patches.

REVISION SUMMARY
  About parameters that have been removed or replaced

REPOSITORY
  rHG Mercurial

BRANCH
  default

REVISION DETAIL
  https://phab.mercurial-scm.org/D11492

AFFECTED FILES
  rust/hg-core/src/dirstate_tree/dispatch.rs

CHANGE DETAILS

diff --git a/rust/hg-core/src/dirstate_tree/dispatch.rs b/rust/hg-core/src/dirstate_tree/dispatch.rs
--- a/rust/hg-core/src/dirstate_tree/dispatch.rs
+++ b/rust/hg-core/src/dirstate_tree/dispatch.rs
@@ -46,11 +46,6 @@
     ) -> Result<(), DirstateV2ParseError>;
 
     /// Add or change the information associated to a given file.
-    ///
-    /// `old_state` is the state in the entry that `get` would have returned
-    /// before this call, or `EntryState::Unknown` if there was no such entry.
-    ///
-    /// `entry.state` should never be `EntryState::Unknown`.
     fn add_file(
         &mut self,
         filename: &HgPath,
@@ -62,25 +57,15 @@
     ) -> Result<(), DirstateError>;
 
     /// Mark a file as "removed" (as in `hg rm`).
-    ///
-    /// `old_state` is the state in the entry that `get` would have returned
-    /// before this call, or `EntryState::Unknown` if there was no such entry.
-    ///
-    /// `size` is not actually a size but the 0 or -1 or -2 value that would be
-    /// put in the size field in the dirstate-v1 format.
     fn remove_file(
         &mut self,
         filename: &HgPath,
         in_merge: bool,
     ) -> Result<(), DirstateError>;
 
-    /// Drop information about this file from the map if any, and return
-    /// whether there was any.
+    /// Drop information about this file from the map if any.
     ///
     /// `get` will now return `None` for this filename.
-    ///
-    /// `old_state` is the state in the entry that `get` would have returned
-    /// before this call, or `EntryState::Unknown` if there was no such entry.
     fn drop_file(&mut self, filename: &HgPath) -> Result<(), DirstateError>;
 
     /// Among given files, mark the stored `mtime` as ambiguous if there is one



To: SimonSapin, #hg-reviewers
Cc: mercurial-patches, mercurial-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mercurial-scm.org/pipermail/mercurial-patches/attachments/20210923/585bf192/attachment.html>


More information about the Mercurial-patches mailing list