[Changed Subscribers] D11377: rhg: add support for calling `rhg cat` without a revision

[SimonSapin]

SimonSapin added inline comments.

INLINE COMMENTS

> cat.rs:63
> +        Some(r) => r.to_string(),
> +        None => format!("{:x}", repo.dirstate_parents()?.p1),
> +    };

What should happen when p1 is null? (Such as in a new empty repository.) Is this case covered by tests?

> cat.rs:63
> +        Some(r) => r.to_string(),
> +        None => format!("{:x}", repo.dirstate_parents()?.p1),
> +    };

Making a hex string just to parse it again feels a bit silly, but is likely required by the current signature of `hg::operations::cat`. That can be refactored later.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D11377/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D11377

To: Alphare, #hg-reviewers
Cc: SimonSapin, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20210902/1397526c/attachment-0002.html>