[Commented On] D11378: rhg-cat: fallback when detecting `.` or `..` path segments

Alphare (Raphaël Gomès) phabricator at mercurial-scm.org
Fri Sep 3 09:27:48 UTC 2021


Alphare added a comment.


  In D11378#174748 <https://phab.mercurial-scm.org/D11378#174748>, @SimonSapin wrote:
  
  > Is https://doc.rust-lang.org/std/fs/fn.canonicalize.html the correct normalization needed here? (Note that it follows symlinks.) If it’s easy enough, it may be worth implementing the correct behavior instead of adding fallback.
  
  This wouldn't work since the normalization must be independent from the fs. You can have `hg cat -r 1 file_that_was_deleted_since_then`, we need to use `HgPath` type normalization.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D11378/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D11378

To: Alphare, #hg-reviewers
Cc: SimonSapin, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20210903/3f3ab651/attachment-0002.html>


More information about the Mercurial-patches mailing list