[Updated] D11380: rhg: fallback if the current command has any generic hook defined

Alphare (Raphaël Gomès) phabricator at mercurial-scm.org
Fri Sep 3 09:43:06 UTC 2021


Alphare added inline comments.

INLINE COMMENTS

> SimonSapin wrote in main.rs:72
> Nit: `"string literals"` have type `&'static str`, so the extra `&` operators are unnecessary. (This `prefix` ends up with triple pointer indirection `&&&str` since `.iter()` adds another one! But by-value array iteration requires Rust 1.53)

Ah, I got confused since I started with `b"pre"` instead of `b"pre"`, which doesn't work since the items differed in size, but it does not apply to `&'static str`, as you mentioned.
We're gonna have to wait for Debian Bookworm for 1.53 I'm pretty sure. ;)

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D11380/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D11380

To: Alphare, #hg-reviewers, SimonSapin
Cc: SimonSapin, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20210903/f99c149d/attachment-0002.html>


More information about the Mercurial-patches mailing list