[Updated] D11389: rhg: Port Python’s `ui.configlist` as `Config::get_list`

[Alphare (Raphaël Gomès)]

This revision is now accepted and ready to land.
Alphare added a comment.
Alphare accepted this revision.


  The Rust replication seems good to me, I don't think the performance aspect is too important either. I'm not glad we have to have this, but I don't have a better solution!

INLINE COMMENTS

> values.rs:241
> +    assert_parse_list!(b"D,\"" => [b"D", b"\""]);
> +    assert_parse_list!(b"E,\"\"" => [b"E", b"", b""]);
> +    assert_parse_list!(b"\"F,F\"" => [b"F,F"]);

nit: I find that these are more readable by using `r#"this kind of string"#`

REPOSITORY
  rHG Mercurial

BRANCH
  default

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D11389/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D11389

To: SimonSapin, #hg-reviewers, Alphare
Cc: Alphare, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20210908/97ad8a2d/attachment-0002.html>