[Updated] D11389: rhg: Port Python’s `ui.configlist` as `Config::get_list`

SimonSapin phabricator at mercurial-scm.org
Thu Sep 9 13:48:22 UTC 2021


SimonSapin added inline comments.

INLINE COMMENTS

> Alphare wrote in values.rs:241
> nit: I find that these are more readable by using `r#"this kind of string"#`

Yes, not having to mentally do backslash-unescaping would certainly be easier for human readers. However these raw strings literals do not support any backslash-escaping so `\t` and `\x0b` would have to be replaced by their literal characters whose difference is less visible to human readers. We could have only those test cases use non-raw literals, but keeping all test cases consistent with each other feels more valuable to me.

REPOSITORY
  rHG Mercurial

BRANCH
  default

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D11389/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D11389

To: SimonSapin, #hg-reviewers, Alphare
Cc: Alphare, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20210909/c7ec5681/attachment-0002.html>


More information about the Mercurial-patches mailing list