[Updated] D11396: rust: Make OwningDirstateMap generic and move it into hg-core

Alphare (Raphaël Gomès) phabricator at mercurial-scm.org
Mon Sep 13 10:25:17 UTC 2021


This revision now requires changes to proceed.
Alphare added a comment.
Alphare requested changes to this revision.


  I feel like the commit message should have a small explanation of why we're switching to using `StableDeref` and what is does.
  
  Other than that, the change looks good, though the `get_mut_pair` name might be a little confusing since only the value part of the pair is mutable, but this is obvious enough from the signature of the function (yay static types?).

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D11396/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D11396

To: SimonSapin, #hg-reviewers, Alphare
Cc: Alphare, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20210913/844474bd/attachment-0002.html>


More information about the Mercurial-patches mailing list