[Updated] D11398: rust: Add Repo::dirstate_map and use it in `rhg status`

[Alphare (Raphaël Gomès)]

This revision is now accepted and ready to land.
Alphare added a comment.
Alphare accepted this revision.


  Cool ! That should speed up some operations, especially with more complex commands.

INLINE COMMENTS

> repo.rs:270
> +        if dirstate_file_contents.is_empty() {
> +            Ok(OwningDirstateMap::new_empty(Vec::new()))
> +        } else if self.has_dirstate_v2() {

Should we set the parents to `DirstateParents::NULL` here?

> repo.rs:311
> +            *self.dirstate_map.borrow_mut() = Some(self.new_dirstate_map()?);
> +            borrowed = self.dirstate_map.borrow()
> +        }

I had no idea you could re-assign to a dropped variable, but I guess it makes sense.

REPOSITORY
  rHG Mercurial

BRANCH
  default

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D11398/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D11398

To: SimonSapin, #hg-reviewers, Alphare
Cc: Alphare, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20210913/e9043b36/attachment-0002.html>