[Updated] D11408: rust: Add a Filelog struct that wraps Revlog

[Alphare (Raphaël Gomès)]

This revision is now accepted and ready to land.
Alphare added inline comments.
Alphare accepted this revision.

INLINE COMMENTS

> filelog.rs:39
> +    /// changeset.
> +    pub fn get_rev(
> +        &self,

The more I look at `get_rev` the more it feels confusing to me. I'm saying this for all revlogs: having a `get_rev(rev)` feels weird, maybe it should be `get_entry(rev)` or something. This would be for another patch, of course, but I thought I'd discuss it

REPOSITORY
  rHG Mercurial

BRANCH
  default

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D11408/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D11408

To: SimonSapin, #hg-reviewers, Alphare
Cc: Alphare, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20210913/e07a7a8b/attachment-0002.html>