[Updated] D11408: rust: Add a Filelog struct that wraps Revlog

SimonSapin phabricator at mercurial-scm.org
Mon Sep 13 20:36:12 UTC 2021


SimonSapin added inline comments.

INLINE COMMENTS

> Alphare wrote in filelog.rs:39
> The more I look at `get_rev` the more it feels confusing to me. I'm saying this for all revlogs: having a `get_rev(rev)` feels weird, maybe it should be `get_entry(rev)` or something. This would be for another patch, of course, but I thought I'd discuss it

How about `get_by_rev` and `get_by_node`? But yes, for another patch

REPOSITORY
  rHG Mercurial

BRANCH
  default

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D11408/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D11408

To: SimonSapin, #hg-reviewers, Alphare
Cc: Alphare, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20210913/2704f921/attachment-0002.html>


More information about the Mercurial-patches mailing list