[Commented On] D11412: rhg: Don’t compare ambiguous files one byte at a time

[Alphare (Raphaël Gomès)]

Alphare added a comment.


  I don't think the buffered one is much worse? I'm fine with the general case being that we don't care about reading the entire file into memory since it should be fast enough, but maybe this will be worth revisiting some day (with a few benchmarks).

INLINE COMMENTS

> Cargo.lock:3
>  # It is not intended for manual editing.
> -version = 3
> -

I think this shouldn't have been included. What is the reason for this, I'm curious?

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D11412/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D11412

To: SimonSapin, #hg-reviewers
Cc: Alphare, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20210913/40138c38/attachment-0002.html>