[Updated] D11445: dirstate: fix compilation warnings in `dirstate_item_set_possibly_dirty()`

[martinvonz (Martin von Zweigbergk)]

martinvonz edited the summary of this revision.
martinvonz updated this revision to Diff 30288.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D11445?vs=30283&id=30288

BRANCH
  default

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D11445/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D11445

AFFECTED FILES
  mercurial/cext/parsers.c

CHANGE DETAILS

diff --git a/mercurial/cext/parsers.c b/mercurial/cext/parsers.c
--- a/mercurial/cext/parsers.c
+++ b/mercurial/cext/parsers.c
@@ -487,9 +487,8 @@
    to make sure it is correct. */
 static PyObject *dirstate_item_set_possibly_dirty(dirstateItemObject *self)
 {
-	if (self->flags |= dirstate_flag_possibly_dirty) {
-		Py_RETURN_NONE;
-	}
+	self->flags |= dirstate_flag_possibly_dirty;
+	Py_RETURN_NONE;
 }
 
 /* See docstring of the python implementation for details */



To: martinvonz, #hg-reviewers, marmoute
Cc: Alphare, marmoute, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20210917/b9ed65fc/attachment-0002.html>