[Commented On] D11444: dirstate: make dirstate flags char be unsigned

[Alphare (Raphaël Gomès)]

Alphare added a comment.


  @martinvonz clangformat complains:
  
    @@ -8,3 +8,18 @@
       >   cmp $f $f.formatted || diff -u $f $f.formatted
       >   rm $f.formatted
       > done
    +  mercurial/cext/parsers.c mercurial/cext/parsers.c.formatted differ: char 3857, line 147
    +  --- mercurial/cext/parsers.c        2021-09-17 15:05:49.010806214 +0000
    +  +++ mercurial/cext/parsers.c.formatted      2021-09-17 15:06:34.139000016 +0000
    +  @@ -144,8 +144,9 @@
    +
    +   static inline bool dirstate_item_c_added(dirstateItemObject *self)
    +   {
    +  -   unsigned char mask = (dirstate_flag_wc_tracked | dirstate_flag_p1_tracked |
    +  -                dirstate_flag_p2_tracked);
    +  +   unsigned char mask =
    +  +       (dirstate_flag_wc_tracked | dirstate_flag_p1_tracked |
    +  +        dirstate_flag_p2_tracked);
    +      unsigned char target = dirstate_flag_wc_tracked;
    +      return (self->flags & mask) == target;
    +   }
  
  I can just amend this if you want.

REPOSITORY
  rHG Mercurial

BRANCH
  default

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D11444/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D11444

To: martinvonz, #hg-reviewers, Alphare, marmoute
Cc: Alphare, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20210917/dd28754b/attachment-0002.html>