[Commented On] D11488: dirstate: Don’t drop unrelated data in DirstateMap::set_entry

[Alphare (Raphaël Gomès)]

Alphare added a comment.


  In D11488#176162 <https://phab.mercurial-scm.org/D11488#176162>, @SimonSapin wrote:
  
  > It would be good to have a CLI-level integration test that’s affected by this but I don’t know how to make one. When and how are used copy source info stored in the dirstate?
  
  When using `hg move` or `hg copy`, basically. It stores the copy information in the dirstate, and it gets committed at the next `hg commit`
  
  > I would not be in favor of adding dirstatemap.py unit tests (at least at the moment) because it’s an internal API that keep changing. As to a low-level unit test for this specific `DirstateMap::set_entry` Rust method, I feel it could only be trivial like "1. Do X 2. Check X is done" and not helpful at finding actual bugs. What matters here is what semantics are expected or not by callers.
  
  Agreed.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D11488/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D11488

To: SimonSapin, #hg-reviewers
Cc: Alphare, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20210923/d66ef478/attachment-0002.html>