[Updated] D11495: narrow: Make hg manifest only print things inside the narrowspec

[Alphare (Raphaël Gomès)]

This revision now requires changes to proceed.
Alphare added a comment.
Alphare requested changes to this revision.


  The change looks good aside from my one comment. The commit description shouldn't be capitalized (after the topic part), I'm not sure why `test-check-commit.t` stopped picking that up.

INLINE COMMENTS

> commands.py:4776
> +            files = ctx.files()
> +            files = filter(m, files)
> +            res |= set(files)

I would add a check for `alwaysmatcher` to not run the filter if it's going to be useless anyway. I expect that large repositories could gain a little by doing this.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D11495/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D11495

To: charlesetc, durin42, #hg-reviewers, Alphare
Cc: Alphare, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20210924/df68b486/attachment-0002.html>