[Commented On] D12458: rust-dirstatemap: add `set_possibly_dirty` method
marmoute (Pierre-Yves David)
phabricator at mercurial-scm.org
Fri Apr 8 12:47:26 UTC 2022
marmoute added inline comments.
INLINE COMMENTS
> Alphare wrote in dirstate_map.rs:808
> I don't think this should affect anything. Setting an entry as `possibly_dirty` does not have any effect on its being tracked or having a copy source, or an entry. The next call to `dirstate.status` will use some other method to reset its state. Or am I missing something?
My question is more "it seems like this call could insert a node, yet nothing is done to adjust the counter associated to this insertion". Is this a legitimate concerns ?
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D12458/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D12458
To: Alphare, #hg-reviewers
Cc: marmoute, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20220408/2c273234/attachment-0002.html>
More information about the Mercurial-patches
mailing list