[Commented On] D12455: dirstatemap: remove `_insert_entry`

[baymax (Baymax, Your Personal Patch-care Companion)]

baymax added a comment.
baymax updated this revision to Diff 32927.


  ✅ refresh by Heptapod after a successful CI run (🐙 💚)

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D12455?vs=32891&id=32927

BRANCH
  default

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D12455/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D12455

AFFECTED FILES
  mercurial/dirstatemap.py

CHANGE DETAILS

diff --git a/mercurial/dirstatemap.py b/mercurial/dirstatemap.py
--- a/mercurial/dirstatemap.py
+++ b/mercurial/dirstatemap.py
@@ -101,12 +101,6 @@
     def _refresh_entry(self, f, entry):
         """record updated state of an entry"""
 
-    def _insert_entry(self, f, entry):
-        """add a new dirstate entry (or replace an unrelated one)
-
-        The fact it is actually new is the responsability of the caller
-        """
-
     def _drop_entry(self, f):
         """remove any entry for file f
 
@@ -511,7 +505,7 @@
             has_meaningful_mtime=has_meaningful_mtime,
             parentfiledata=parentfiledata,
         )
-        self._insert_entry(filename, entry)
+        self._map[filename] = entry
 
     def set_tracked(self, filename):
         new = False
@@ -522,7 +516,7 @@
                 wc_tracked=True,
             )
 
-            self._insert_entry(filename, entry)
+            self._map[filename] = entry
             new = True
         elif not entry.tracked:
             self._dirs_incr(filename, entry)
@@ -541,9 +535,6 @@
         if not entry.any_tracked:
             self._map.pop(f, None)
 
-    def _insert_entry(self, f, entry):
-        self._map[f] = entry
-
     def _drop_entry(self, f):
         self._map.pop(f, None)
         self.copymap.pop(f, None)
@@ -718,9 +709,6 @@
             else:
                 self._map.addfile(f, entry)
 
-        def _insert_entry(self, f, entry):
-            self._map.addfile(f, entry)
-
         def set_tracked(self, f):
             return self._map.set_tracked(f)
 



To: Alphare, #hg-reviewers, marmoute
Cc: marmoute, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20220408/c95acd6c/attachment-0002.html>