[Commented On] D12473: rust-dirstatemap: remove `set_dirstate_entry`/`set_entry` methods
baymax (Baymax, Your Personal Patch-care Companion)
phabricator at mercurial-scm.org
Fri Apr 8 16:31:21 UTC 2022
baymax added a comment.
baymax updated this revision to Diff 32945.
✅ refresh by Heptapod after a successful CI run (🐙 💚)
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D12473?vs=32909&id=32945
BRANCH
default
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D12473/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D12473
AFFECTED FILES
rust/hg-core/src/dirstate_tree/dirstate_map.rs
rust/hg-cpython/src/dirstate/dirstate_map.rs
CHANGE DETAILS
diff --git a/rust/hg-cpython/src/dirstate/dirstate_map.rs b/rust/hg-cpython/src/dirstate/dirstate_map.rs
--- a/rust/hg-cpython/src/dirstate/dirstate_map.rs
+++ b/rust/hg-cpython/src/dirstate/dirstate_map.rs
@@ -104,20 +104,6 @@
}
}
- def set_dirstate_item(
- &self,
- path: PyObject,
- item: DirstateItem
- ) -> PyResult<PyObject> {
- let f = path.extract::<PyBytes>(py)?;
- let filename = HgPath::new(f.data(py));
- self.inner(py)
- .borrow_mut()
- .set_entry(filename, item.get_entry(py))
- .map_err(|e| v2_error(py, e))?;
- Ok(py.None())
- }
-
def set_tracked(&self, f: PyObject) -> PyResult<PyBool> {
let bytes = f.extract::<PyBytes>(py)?;
let path = HgPath::new(bytes.data(py));
diff --git a/rust/hg-core/src/dirstate_tree/dirstate_map.rs b/rust/hg-core/src/dirstate_tree/dirstate_map.rs
--- a/rust/hg-core/src/dirstate_tree/dirstate_map.rs
+++ b/rust/hg-core/src/dirstate_tree/dirstate_map.rs
@@ -884,17 +884,6 @@
});
}
- pub fn set_entry(
- &mut self,
- filename: &HgPath,
- entry: DirstateEntry,
- ) -> Result<(), DirstateV2ParseError> {
- self.with_dmap_mut(|map| {
- map.get_or_insert(&filename)?.data = NodeData::Entry(entry);
- Ok(())
- })
- }
-
pub fn set_tracked(
&mut self,
filename: &HgPath,
To: Alphare, #hg-reviewers, marmoute
Cc: marmoute, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20220408/9d58b65f/attachment-0002.html>
More information about the Mercurial-patches
mailing list