[Commented On] D12443: dirstate: fix some typos in docstrings

Alphare (Raphaël Gomès) phabricator at mercurial-scm.org
Fri Apr 8 17:51:14 UTC 2022


Alphare added a comment.


  In D12443#191192 <https://phab.mercurial-scm.org/D12443#191192>, @martinvonz wrote:
  
  > The script that runs on mercurial-scm.org checks for unchanged diffs, so I think what happened is that I pushed your commits, which implicitly marks them accepted by me. Then you rebased them and pushed them, which resulted in you accepting them as well. In the cases where the diffs were unchanged, the script would make them public.
  
  Right, I thought this was something to do with this. This adds more fuel to my fire about the review tooling. :D
  
  > I don't think Phabricator is involved in the pushing or publishing.
  
  I was specifically targeting Phab because it's the current default review tool, it doesn't understand obsolescence and is out-of-band, but it's the entire review system that needs an overhaul.
  
  > I got the impression a long time ago that the Rust code was an experiment by Octobus that I shouldn't slow down by reviewing and commenting. Since it's experimental and not enabled by default, that seemed fine to me. Sorry if I misunderstood. I'll review Rust code as well from now on.
  
  I have always received some amount of review on the Rust code, I'm not sure if this was ever the case, but maybe before my time in Mercurial. Thanks for confirming then. I certainly appreciate the sentiment of "I shouldn't slow down by reviewing and commenting", and trusting some people with experience but without reviewer rights (like marmoute or Simon formerly) can be a valid way of speeding it up IMO, but the code is now being used by a fair amount of people, so it still needs review by *somebody*.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D12443/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D12443

To: Alphare, #hg-reviewers, marmoute
Cc: martinvonz, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20220408/de755ac5/attachment-0002.html>


More information about the Mercurial-patches mailing list