[Updated] D12546: rust-revlog: move check for nodemap requirement to caller
martinvonz (Martin von Zweigbergk)
phabricator at mercurial-scm.org
Fri Apr 15 16:53:59 UTC 2022
martinvonz added a comment.
In D12546#192136 <https://phab.mercurial-scm.org/D12546#192136>, @Alphare wrote:
> In D12546#192112 <https://phab.mercurial-scm.org/D12546#192112>, @martinvonz wrote:
>
>> - I was thinking of moving the conditions further up the stack, to the repo level. If we do that, then the repo might be a natural place to extract a function. Or maybe I'll put it in `nodemap.rs` as you said. I'll update this patch a bit later.
>
> Either seem fine to me.
I moved it to `Repo` in D12562 <https://phab.mercurial-scm.org/D12562>.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D12546/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D12546
To: martinvonz, #hg-reviewers, Alphare
Cc: Alphare, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20220415/b12c933e/attachment-0002.html>
More information about the Mercurial-patches
mailing list