[Commented On] D12580: rust-dirstate-v2: save proper data size if no new data on append

[martinvonz (Martin von Zweigbergk)]

martinvonz added a comment.


  In D12580#192736 <https://phab.mercurial-scm.org/D12580#192736>, @Alphare wrote:
  
  > In D12580#192721 <https://phab.mercurial-scm.org/D12580#192721>, @martinvonz wrote:
  >
  >> It looks like the tests from your other long series need to be updated in this patch (they don't compile with this patch applied).
  >
  > You may have missed my first comment here then. This patch is destined for `stable` where it should apply cleanly, only the merge will need to be adapted .
  
  Ah, you're right that I missed that (well, I forgot about it). Sorry.
  
  > In D12580#192702 <https://phab.mercurial-scm.org/D12580#192702>, @aalekseyev wrote:
  >
  >> Relevant issue: https://github.com/prometheus/prometheus/issues/484.
  >> Presumably hg has reasonable expectations here, the bug is in ZFS. However this does mean that we in Jane Street will experience issues since we don't seem to have a patched ZFS.
  >> This also means that this code path is untested, yes? (Since I'm not seeing any errors) Do you know how to reproduce the append behavior so we have a test that breaks on buggy ZFS?
  >
  > This is very interesting, thanks for the investigation. It is indeed untested, I can follow up with a test soon (but not this week).
  
  Since @aalekseyev seemed happy with the patch in it's current form, I suppose I can queue it now and you add those tests in a separate patch. Thanks.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D12580/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D12580

To: Alphare, #hg-reviewers, aalekseyev, martinvonz
Cc: martinvonz, aalekseyev, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20220422/d178a0c5/attachment-0002.html>