[Requested Changes] D12002: precheck: fix false warning about content-divergence creation

[marmoute (Pierre-Yves David)]

marmoute added inline comments.
marmoute requested changes to this revision.

INLINE COMMENTS

> martinvonz wrote in rewriteutil.py:89
> Depending on `action` seems ugly. What if I create my own `hg pare` command with similar behavior, then I still need to pass "prune" here and my users would see that in error messages? Also `successors` is used only here... Can we simply pass a `check_divergence=True` instead?

I agree with martin that we should not use the `action` here. The actions are purely here to provides some information to the users, and shouldn't be used for logic.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D12002/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D12002

To: khanchi97, #hg-reviewers, martinvonz, marmoute
Cc: marmoute, martinvonz, mharbison72, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mercurial-scm.org/pipermail/mercurial-patches/attachments/20220202/c18c3aa6/attachment-0001.html>