[Updated] D12097: branchmap: skip obsolete revisions while computing heads

[av6 (Anton Shestakov)]

av6 added inline comments.

INLINE COMMENTS

> marmoute wrote in branchmap.py:352-355
> Small nit: we should probably split this four-liner into individual statement.

Yeah, I added this todo item to my follow-up list, because I'd like to update the docstring as well.

> marmoute wrote in scmutil.py:369
> The use of `frozenset` on the obsolete set here is unfortunate. As mean a significant computation just to validate the inner cache key.
> 
> Please add a comment about this.
> 
> I am not sur why the obsrevs are not a frozenset already so we should look into that (outside of this series).

I'll send a follow-up to make obsolete.getrevs() always return frozensets when this series lands.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D12097/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D12097

To: av6, #hg-reviewers
Cc: marmoute, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20220203/6d915958/attachment-0002.html>