[Commented On] D12139: rank: naive rank property computation and retrieval

[Alphare (Raphaël Gomès)]

Alphare added a comment.


  One thing that isn't clear is exactly what the rank is going to be used for (at least its currently foreseeable applications) to people not privy to the details, so probably adding a sentence to the commit message about this might be a good idea.

INLINE COMMENTS

> revlog.py:877
>  
> +    def fast_rank(self, rev):
> +        """The "rank" of the revision if available, None otherwise

Why is this called `fast_rank`? Are we expecting to have a (possibly slower) `def rank` somewhere down the line?

> revlog.py:881
> +        The rank of a revision is the size of sub-graph it defines as a head.
> +        In other words, the rank og X i sthe size of `ancestors(X)` (X
> +        included).

"the rank og X i sthe size of" => "the rank of X is the size of"

> revlog.py:884
> +
> +        Some variant of revlog persist this value and make it available.
> +        """

s/variant/variants/

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D12139/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D12139

To: pacien, #hg-reviewers
Cc: Alphare, marmoute, joerg.sonnenberger, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20220208/50ea81f4/attachment-0002.html>