[Commented On] D12139: rank: naive rank property computation and retrieval
Alphare (Raphaël Gomès)
phabricator at mercurial-scm.org
Tue Feb 8 15:09:55 UTC 2022
Alphare added inline comments.
INLINE COMMENTS
> marmoute wrote in revlog.py:877
> It is a the `fast_rank` because it a cached value that can be retreived in O(N). Not a computed value that would be expensive to compute. Using the rank when available could help various algorithm (outside of the initial target) for example ancestors checking or discovery. However it is unlikely to be worth computing the rank of the fly for these usecases.
You mean `O(1)` right?
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D12139/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D12139
To: pacien, #hg-reviewers, Alphare
Cc: Alphare, marmoute, joerg.sonnenberger, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20220208/87159cf8/attachment-0002.html>
More information about the Mercurial-patches
mailing list