[Updated] [+ ] D12151: simplemerge: remove now-unused `ui` argument

martinvonz (Martin von Zweigbergk) phabricator at mercurial-scm.org
Tue Feb 8 22:10:55 UTC 2022


martinvonz updated this revision to Diff 32105.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D12151?vs=32100&id=32105

BRANCH
  default

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D12151/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D12151

AFFECTED FILES
  contrib/simplemerge
  mercurial/filemerge.py
  mercurial/simplemerge.py

CHANGE DETAILS

diff --git a/mercurial/simplemerge.py b/mercurial/simplemerge.py
--- a/mercurial/simplemerge.py
+++ b/mercurial/simplemerge.py
@@ -495,7 +495,7 @@
                 raise error.Abort(msg)
 
 
-def simplemerge(ui, local, base, other, **opts):
+def simplemerge(local, base, other, **opts):
     """Performs the simplemerge algorithm.
 
     The merged result is written into `localctx`.
diff --git a/mercurial/filemerge.py b/mercurial/filemerge.py
--- a/mercurial/filemerge.py
+++ b/mercurial/filemerge.py
@@ -437,7 +437,7 @@
             return 1
         else:
             merged_text, conflicts = simplemerge.simplemerge(
-                ui, local, base, other, mode=mode
+                local, base, other, mode=mode
             )
             if merged_text is not None and (
                 not conflicts or premerge in validkeep
@@ -488,7 +488,7 @@
         conflicts = True
     else:
         merged_text, conflicts = simplemerge.simplemerge(
-            ui, local, base, other, mode=mode
+            local, base, other, mode=mode
         )
         # fcd.flags() already has the merged flags (done in
         # mergestate.resolve())
diff --git a/contrib/simplemerge b/contrib/simplemerge
--- a/contrib/simplemerge
+++ b/contrib/simplemerge
@@ -107,7 +107,7 @@
         sys.exit(1)
 
     merged_text, conflicts = simplemerge.simplemerge(
-        ui, local_input, base_input, other_input, **opts
+        local_input, base_input, other_input, **opts
     )
     if merged_text is not None:
         if opts['print']:



To: martinvonz, #hg-reviewers
Cc: mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20220208/e32af798/attachment-0002.html>


More information about the Mercurial-patches mailing list