[Commented On] D12147: simplemerge: let users call verifytext()

[martinvonz (Martin von Zweigbergk)]

martinvonz added a comment.
martinvonz planned changes to this revision.


  In D12147#186335 <https://phab.mercurial-scm.org/D12147#186335>, @Alphare wrote:
  
  > I am not entirely sure if removing the check from `simplemerge` is a good idea, new callers would need to think to verify the text beforehand. Maybe a `_verified` attribute could be used to skip the check if already done?
  
  Yes, that's fair. I'll refactor this in some way. I'd still like to remove the `ui` argument from `simplemerge()` because it seems like a library function to me (though I know we don't separate between library and UI almost anywhere :)).

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D12147/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D12147

To: martinvonz, #hg-reviewers
Cc: Alphare, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20220209/7b84f277/attachment-0002.html>