[Updated] D12157: scmutil: obsrevs is already a frozenset

av6 (Anton Shestakov) phabricator at mercurial-scm.org
Thu Feb 10 09:34:56 UTC 2022


Closed by commit rHGc7e675848027: scmutil: obsrevs is already a frozenset (authored by av6).
This revision was automatically updated to reflect the committed changes.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D12157?vs=32109&id=32117

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D12157/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D12157

AFFECTED FILES
  mercurial/scmutil.py

CHANGE DETAILS

diff --git a/mercurial/scmutil.py b/mercurial/scmutil.py
--- a/mercurial/scmutil.py
+++ b/mercurial/scmutil.py
@@ -366,9 +366,7 @@
         obsrevs = obsolete.getrevs(repo, b'obsolete')
         if not cl.filteredrevs and not obsrevs:
             return None
-        # TODO: obsrevs should be a frozenset, but right now obsolete.getrevs()
-        # may return a set, which is not a hashable type.
-        key = (maxrev, hash(cl.filteredrevs), hash(frozenset(obsrevs)))
+        key = (maxrev, hash(cl.filteredrevs), hash(obsrevs))
     else:
         if not cl.filteredrevs:
             return None



To: av6, #hg-reviewers, Alphare
Cc: mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20220210/b906bb5f/attachment-0002.html>


More information about the Mercurial-patches mailing list