[Commented On] D12166: rhg: Add parsing for the --color global CLI argument
Alphare (Raphaël Gomès)
phabricator at mercurial-scm.org
Sun Feb 13 10:53:09 UTC 2022
Alphare added inline comments.
INLINE COMMENTS
> SimonSapin wrote in layer.rs:308
> Right, I’ll remove the CLI one.
>
> The others may still be relevant. Maybe not defaults if we keep the current pattern of `.get(…).unwrap_or(default_value)` at use sites instead of centralized defaults definition.
I think the others are still relevant. We should think about `configitems.py` at some point, so let's keep it.
REPOSITORY
rHG Mercurial
BRANCH
default
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D12166/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D12166
To: SimonSapin, #hg-reviewers, Alphare
Cc: Alphare, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20220213/ee4fdc40/attachment-0002.html>
More information about the Mercurial-patches
mailing list