[Changed Subscribers] D12178: revlog: implement changelogv2 packing and unpacking in C

Alphare (Raphaël Gomès) phabricator at mercurial-scm.org
Tue Feb 15 13:46:16 UTC 2022


Alphare added inline comments.

INLINE COMMENTS

> revlog.c:466
> +		uncomp_len = getbe32(data + entry_cl2_offset_uncomp_len);
> +		base_rev = pos;
> +		link_rev = pos;

Maybe a small comment here saying that we need the base_rev and link_rev because they're declared but they're useless in clv2?

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D12178/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D12178

To: pacien, #hg-reviewers
Cc: Alphare, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20220215/7a331489/attachment-0002.html>


More information about the Mercurial-patches mailing list