[Updated] D12195: obsolete: don't use os.stat in repo.obsstore.__nonzero__ if it's static HTTP

Alphare (Raphaël Gomès) phabricator at mercurial-scm.org
Wed Feb 16 09:33:57 UTC 2022


This revision now requires changes to proceed.
Alphare added inline comments.
Alphare requested changes to this revision.

INLINE COMMENTS

> obsolete.py:582
> +            # to just peek at the file size.
> +            return self._data > 1
>          if not self._cached('_all'):

Shouldn't this be `len(self._data) > 1`?

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D12195/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D12195

To: av6, #hg-reviewers, Alphare
Cc: Alphare, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20220216/f029b638/attachment-0002.html>


More information about the Mercurial-patches mailing list