[Updated] D12201: tracked-key: remove the dual write and rename to tracked-hint

Alphare (Raphaël Gomès) phabricator at mercurial-scm.org
Thu Feb 17 10:55:06 UTC 2022


This revision now requires changes to proceed.
Alphare added inline comments.
Alphare requested changes to this revision.

INLINE COMMENTS

> config.txt:958
> +    - the second line contains the "tracked-hint".
> +    That file is writtent right after the dirstate is written.
> +

s/writtent/written/

> config.txt:965
> +
> +    The "identical" use a should is a `SHOULD` as the dirstate and the hint file
> +    are two distinct files and therefore that cannot be read or write in an

"The "identical" use a should is a `SHOULD`" Not sure what the intended phrasing was

> config.txt:969
> +    not updated right after the hint file. This is considered a negligible
> +    limitation for the intended usecase. It isi actually possible to prevent this race by
> +    taking the repository lock during read operation.

s/isi/is/

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D12201/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D12201

To: marmoute, #hg-reviewers, Alphare
Cc: Alphare, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20220217/55c33ca0/attachment-0002.html>


More information about the Mercurial-patches mailing list