[Commented On] D11814: rhg: signal when falling back in logs
baymax (Baymax, Your Personal Patch-care Companion)
phabricator at mercurial-scm.org
Fri Jan 14 15:41:42 UTC 2022
baymax added a comment.
baymax updated this revision to Diff 31653.
â
refresh by Heptapod after a successful CI run (ð ð)
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D11814?vs=31138&id=31653
BRANCH
default
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D11814/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D11814
AFFECTED FILES
rust/rhg/src/main.rs
rust/rhg/src/ui.rs
CHANGE DETAILS
diff --git a/rust/rhg/src/ui.rs b/rust/rhg/src/ui.rs
--- a/rust/rhg/src/ui.rs
+++ b/rust/rhg/src/ui.rs
@@ -130,3 +130,9 @@
let bytes = s.as_bytes();
Cow::Borrowed(bytes)
}
+
+/// Decode user system bytes to Rust string.
+pub fn local_to_utf8(s: &[u8]) -> Cow<str> {
+ // TODO decode from the user's system //
+ String::from_utf8_lossy(s)
+}
diff --git a/rust/rhg/src/main.rs b/rust/rhg/src/main.rs
--- a/rust/rhg/src/main.rs
+++ b/rust/rhg/src/main.rs
@@ -1,6 +1,6 @@
extern crate log;
use crate::error::CommandError;
-use crate::ui::Ui;
+use crate::ui::{local_to_utf8, Ui};
use clap::App;
use clap::AppSettings;
use clap::Arg;
@@ -364,7 +364,7 @@
) -> ! {
if let (
OnUnsupported::Fallback { executable },
- Err(CommandError::UnsupportedFeature { .. }),
+ Err(CommandError::UnsupportedFeature { message }),
) = (&on_unsupported, &result)
{
let mut args = std::env::args_os();
@@ -394,6 +394,8 @@
));
on_unsupported = OnUnsupported::Abort
} else {
+ log::debug!("falling back (see trace-level log)");
+ log::trace!("{}", local_to_utf8(message));
// `args` is now `argv[1..]` since weâve already consumed
// `argv[0]`
let mut command = Command::new(executable_path);
To: Alphare, #hg-reviewers
Cc: mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mercurial-scm.org/pipermail/mercurial-patches/attachments/20220114/0463b1d3/attachment.html>
More information about the Mercurial-patches
mailing list