[Updated] D12011: filemerge: remove unnecessary check for empty string

martinvonz (Martin von Zweigbergk) phabricator at mercurial-scm.org
Mon Jan 24 17:29:46 UTC 2022


Closed by commit rHG1a84758b4fca: filemerge: remove unnecessary check for empty string (authored by martinvonz).
This revision was automatically updated to reflect the committed changes.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D12011?vs=31711&id=31824

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D12011/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D12011

AFFECTED FILES
  mercurial/filemerge.py

CHANGE DETAILS

diff --git a/mercurial/filemerge.py b/mercurial/filemerge.py
--- a/mercurial/filemerge.py
+++ b/mercurial/filemerge.py
@@ -837,9 +837,7 @@
 
     label = (b'%s:' % label).ljust(pad + 1)
     mark = b'%s %s' % (label, templateresult)
-
-    if mark:
-        mark = mark.splitlines()[0]  # split for safety
+    mark = mark.splitlines()[0]  # split for safety
 
     # 8 for the prefix of conflict marker lines (e.g. '<<<<<<< ')
     return stringutil.ellipsis(mark, 80 - 8)



To: martinvonz, #hg-reviewers, Alphare
Cc: mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20220124/872a63ba/attachment-0002.html>


More information about the Mercurial-patches mailing list