[Updated] D11994: requirements: do not warn about dropping share-safe, unless explicitly set

marmoute (Pierre-Yves David) phabricator at mercurial-scm.org
Tue Jan 25 09:29:13 UTC 2022


Closed by commit rHG4c1135d15700: requirements: do not warn about dropping share-safe, unless explicitly set (authored by marmoute).
This revision was automatically updated to reflect the committed changes.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D11994?vs=31862&id=31973

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D11994/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D11994

AFFECTED FILES
  mercurial/localrepo.py

CHANGE DETAILS

diff --git a/mercurial/localrepo.py b/mercurial/localrepo.py
--- a/mercurial/localrepo.py
+++ b/mercurial/localrepo.py
@@ -3719,13 +3719,13 @@
             )
 
         if requirementsmod.SHARESAFE_REQUIREMENT in requirements:
-            ui.warn(
-                _(
+            if ui.hasconfig(b'format', b'use-share-safe'):
+                msg = _(
                     b"ignoring enabled 'format.use-share-safe' config because "
                     b"it is incompatible with disabled 'format.usestore'"
                     b" config\n"
                 )
-            )
+                ui.warn(msg)
             dropped.add(requirementsmod.SHARESAFE_REQUIREMENT)
 
     return dropped



To: marmoute, #hg-reviewers, Alphare
Cc: mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20220125/4f8c9f7a/attachment-0002.html>


More information about the Mercurial-patches mailing list