[Commented On] D12413: stringutil: try to avoid running `splitlines()` only to get first line

[martinvonz (Martin von Zweigbergk)]

martinvonz added a comment.


  In D12413#189957 <https://phab.mercurial-scm.org/D12413#189957>, @joerg.sonnenberger wrote:
  
  > Note that you should at least try to check if `text[i-1]` is `\r`, otherwise the result changes from before. I'm perfectly fine with not supporting the ancient Mac convention of using `\r` only, but we should work properly for DOS-style `\r\n`.
  
  How does the behavior change when using `\r\n`?
  
  I should also update the commit message with s/Windows/Mac/. Thanks for pointing that out.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D12413/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D12413

To: martinvonz, #hg-reviewers
Cc: joerg.sonnenberger, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20220327/8fc2312a/attachment-0002.html>