[Updated] D12627: worker: adapt _blockingreader to work around a python3.8.[0-1] bug (issue6444)
Alphare (Raphaël Gomès)
phabricator at mercurial-scm.org
Wed May 18 23:16:16 UTC 2022
This revision now requires changes to proceed.
Alphare added a comment.
Alphare requested changes to this revision.
> I *think* you're supposed to open a "merge request" on https://foss.heptapod.net/mercurial/mercurial-devel these days. Right, @Alphare?
Right!
> I didn't think we made the switch yet, but I'm fine doing that as a pilot. (I ended up amending a commit comment typo since the last push, so it will need to run CI again.)
I have actually already merged a couple of MRs using Heptapod.
> The reason I suggested it was that I queued the patch and tried to push it to hg-committed, but that failed and told me to create a merge request instead. So I suppose it's actually you who should create that merge request since it's your patch. I'm not sure I understood it correctly, though.
Yup. Phabricator is deprecated and slated for read-only state on/around June 1st. The deprecation means that any new patches should be sent to Heptapod unless absolutely infeasible (because something is terribly broken), and old patches will be reviewed here, then put in a topic by yours truly for a CI pass and merged accordingly. Any diff that still needs review/turn-around by June 1st will need to be resent through Heptapod.
@mharbison72 you should have no trouble at all since you're already using Hetpapod for the CI. Please read the contributor guide here: https://www.mercurial-scm.org/wiki/Heptapod
I hope I'm clear, it's very late and my brain is half-working. :)
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D12627/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D12627
To: mharbison72, #hg-reviewers, mjacob, Alphare
Cc: martinvonz, Alphare, mjacob, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20220518/9721023b/attachment-0002.html>
More information about the Mercurial-patches
mailing list