[Updated] D12628: worker: fix `_blockingreader.read()` to really block

mjacob (Manuel Jacob) phabricator at mercurial-scm.org
Fri May 20 02:17:42 UTC 2022


This revision now requires changes to proceed.
mjacob added a comment.
mjacob requested changes to this revision.


  `self._wrapped` is not non-blocking, therefore `self._wrapped.readinto()` won’t ever return `None`, therefore this change only adds dead code.
  
  The name of the class `_blockingreader` is misleading.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D12628/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D12628

To: mharbison72, #hg-reviewers, mjacob
Cc: mjacob, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20220520/4fad9213/attachment-0002.html>


More information about the Mercurial-patches mailing list