[Commented On] D12628: worker: fix `_blockingreader.read()` to really block

[mharbison72 (Matt Harbison)]

mharbison72 added a comment.
mharbison72 abandoned this revision.


  In D12628#193384 <https://phab.mercurial-scm.org/D12628#193384>, @mjacob wrote:
  
  > `self._wrapped` is not non-blocking, therefore `self._wrapped.readinto()` won’t ever return `None`, therefore this change only adds dead code.
  > The name of the class `_blockingreader` is misleading.
  
  I'm totally lost then- what's the point of this wrapper?

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D12628/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D12628

To: mharbison72, #hg-reviewers, mjacob
Cc: mjacob, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20220520/8a682741/attachment-0002.html>